From 6d8f33250074d557ab79591012286d8178b05477 Mon Sep 17 00:00:00 2001
From: Abdelrahman <said.abdelrahman89@gmail.com>
Date: Sun, 4 Feb 2024 17:32:57 +0000
Subject: [PATCH] Improve readability
---
src/raytracer/main.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/raytracer/main.c b/src/raytracer/main.c
index 1d4b455..15d2f21 100644
--- a/src/raytracer/main.c
+++ b/src/raytracer/main.c
@@ -237,13 +237,14 @@ intersection_t find_closest_intersection(vec3f_t origin, vec3f_t direction,
f32 calculate_lighting_for_intersection(vec3f_t origin, vec3f_t direction,
intersection_t intersection,
const scene_t *scene) {
- vec3f_t position = vec_add(
- vec3f_t, origin, vec_mul_num(vec3f_t, direction, intersection.closest_t));
+ vec3f_t _direction = vec_mul_num(vec3f_t, direction, intersection.closest_t);
+ vec3f_t position = vec_add(vec3f_t, origin, _direction);
vec3f_t surface_normal =
vec_sub(vec3f_t, position, intersection.closest_sphere->centre);
- surface_normal = vec_div_num(vec3f_t, surface_normal,
- vec_magnitude(vec3f_t, surface_normal));
+
+ f32 normal_magnitude = vec_magnitude(vec3f_t, surface_normal);
+ surface_normal = vec_div_num(vec3f_t, surface_normal, normal_magnitude);
vec3f_t view_vector = vec_mul_num(vec3f_t, direction, -1.0f);