8086_sim/include/reg_access.h

@@ -4,8 +4,6 @@
 #include "aliases.h"
 #include "sim86_instruction.h"
 
-#define REGISTER_COUNT 13
-
 void set_register(register_access reg, u16 new_value);
 u16 get_register(register_access reg);
 const char *get_register_name(register_access reg);

8086_sim/listing_0045_challenge_register_movs

@@ -0,0 +1 @@
+И""ЛDDЙffК<66><D09A><EFBFBD>а<EFBFBD>л<EFBFBD>С

8086_sim/reg_access.cpp

@@ -2,9 +2,9 @@
 #include "include/aliases.h"
 #include <stdio.h>
 
-static u16 registers[REGISTER_COUNT] = {0};
+#define REGISTER_COUNT 13
 
-#define BIT_PER_BYTE 8
+static u16 registers[REGISTER_COUNT] = {0};
 
 void set_register(register_access reg, u16 new_value) {
   if (reg.Count == 2) {
@@ -12,7 +12,7 @@ void set_register(register_access reg, u16 new_value) {
     return;
   }
 
-  u16 shift = (u16)(reg.Offset) * BIT_PER_BYTE;
+  u16 shift = (u16)(reg.Offset) * (u16)sizeof(u8);
   u16 mask = 0xff00;
 
   registers[reg.Index] &= (mask >> shift);
@@ -24,10 +24,8 @@ u16 get_register(register_access reg) {
     return registers[reg.Index];
   }
 
-  u16 shift = (u16)(reg.Offset) * BIT_PER_BYTE;
-  u16 mask = 0x00ff;
-
-  return (registers[reg.Index] >> shift) & mask;
+  // TODO (Abdelrahman): Implement this
+  return 0;
 }
 
 const char *get_register_name(register_access reg) {

8086_sim/sim86.cpp

@@ -42,8 +42,6 @@ int main(int argc, char *argv[]) {
 
   u32 offset = 0;
 
-  bool accessed_registers[REGISTER_COUNT] = {false};
-
   while (offset < size) {
     instruction decoded;
     Sim86_Decode8086Instruction(size - offset, buffer + offset, &decoded);
@@ -57,22 +55,13 @@ int main(int argc, char *argv[]) {
 
         if (dest.Type == Operand_Register) {
           mov_to_register(dest.Register, source);
-
-          accessed_registers[dest.Register.Index] = true;
+          printf("%s: 0x%04x\n", get_register_name(dest.Register),
+                 get_register(dest.Register));
         }
       }
     }
   }
 
-  for (u32 i = 0; i < REGISTER_COUNT; ++i) {
-    if (accessed_registers[i]) {
-      register_access reg = {i, 0, 2};
-      u16 value = get_register(reg);
-
-      printf("%s: 0x%04x (%d)\n", get_register_name(reg), value, value);
-    }
-  }
-
   return 0;
 }