Fix cppcheck errors

This commit is contained in:
abdelrahman committed 2023-08-06 22:13:14 +01:00
1 parent 866aaa9011
commit 918de7bce0
2 files changed
+20 -18

No files matched your search

+2 -1
View File
@@ -75,7 +75,8 @@ void clip_texture_render_rects_to_drawing_area(RenderRect *src,
RenderRect *dest); RenderRect *dest);
RenderRect get_texture_asset_rect(AssetID id); RenderRect get_texture_asset_rect(AssetID id);
void render_texture_asset(AssetID id, RenderRect *src, RenderRect *dest); void render_texture_asset(AssetID id, const RenderRect *src,
const RenderRect *dest);
void modulate_texture_color(AssetID id, SDL_Color color); void modulate_texture_color(AssetID id, SDL_Color color);
void modulate_texture_alpha(AssetID id, u8 alpha); void modulate_texture_alpha(AssetID id, u8 alpha);
TextSize get_text_size_from_font_asset(AssetID id, const char *text); TextSize get_text_size_from_font_asset(AssetID id, const char *text);
+18 -17
View File
@@ -316,7 +316,8 @@ RenderRect get_texture_asset_rect(AssetID id) {
return rect; return rect;
} }
void render_texture_asset(AssetID id, RenderRect *src, RenderRect *dest) { void render_texture_asset(AssetID id, const RenderRect *src,
const RenderRect *dest) {
if (id < 0) { if (id < 0) {
return; return;
} }
@@ -460,7 +461,7 @@ void pause_audio_asset_on_track(AssetID id, u8 track) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk || chunk != Mix_GetChunk(track)) { if (!chunk || chunk != Mix_GetChunk(track)) {
return; return;
} }
@@ -473,7 +474,7 @@ void resume_audio_asset_on_track(AssetID id, u8 track) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk || chunk != Mix_GetChunk(track)) { if (!chunk || chunk != Mix_GetChunk(track)) {
return; return;
} }
@@ -486,7 +487,7 @@ void stop_audio_asset_on_track(AssetID id, u8 track) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk || chunk != Mix_GetChunk(track)) { if (!chunk || chunk != Mix_GetChunk(track)) {
return; return;
} }
@@ -500,7 +501,7 @@ void fade_out_audio_asset_on_track(AssetID id, u8 track,
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk || chunk != Mix_GetChunk(track)) { if (!chunk || chunk != Mix_GetChunk(track)) {
return; return;
} }
@@ -513,7 +514,7 @@ void pause_all_instances_of_audio_asset(AssetID id) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk) { if (!chunk) {
return; return;
} }
@@ -532,7 +533,7 @@ void resume_all_instances_of_audio_asset(AssetID id) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk) { if (!chunk) {
return; return;
} }
@@ -551,7 +552,7 @@ void stop_all_instances_of_audio_asset(AssetID id) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk) { if (!chunk) {
return; return;
} }
@@ -570,7 +571,7 @@ void fade_out_all_instances_of_audio_asset(AssetID id, u32 fade_length_in_ms) {
return; return;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk) { if (!chunk) {
return; return;
} }
@@ -589,7 +590,7 @@ i8 get_audio_asset_volume(AssetID id) {
return -1; return -1;
} }
Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id); const Mix_Chunk *chunk = get_audio_chunk(GameEngine.asset_manager, id);
if (!chunk) { if (!chunk) {
return -1; return -1;
} }
@@ -633,7 +634,7 @@ void pause_music_asset(AssetID id) {
return; return;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return; return;
} }
@@ -646,7 +647,7 @@ void resume_music_asset(AssetID id) {
return; return;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return; return;
} }
@@ -659,7 +660,7 @@ void stop_music_asset(AssetID id) {
return; return;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return; return;
} }
@@ -672,7 +673,7 @@ void fade_out_music_asset(AssetID id, u32 fade_length_in_ms) {
return; return;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return; return;
} }
@@ -698,7 +699,7 @@ void set_music_asset_volume(AssetID id, i8 volume) {
return; return;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return; return;
} }
@@ -706,7 +707,7 @@ void set_music_asset_volume(AssetID id, i8 volume) {
Mix_VolumeMusic(volume); Mix_VolumeMusic(volume);
} }
bool is_music_object_playing(Mix_Music *music) { bool is_music_object_playing(const Mix_Music *music) {
if (!Mix_PlayingMusic()) { if (!Mix_PlayingMusic()) {
return false; return false;
} }
@@ -729,7 +730,7 @@ bool is_music_asset_playing(AssetID id) {
return false; return false;
} }
Mix_Music *music = get_music(GameEngine.asset_manager, id); const Mix_Music *music = get_music(GameEngine.asset_manager, id);
if (!music) { if (!music) {
return false; return false;
} }