Fix MSVC build issues

src/base/array/array.c

@@ -205,7 +205,9 @@ void arrayRemoveSwapEnd(WpArray array, u64 index, u64 item_size) {
 
 	u64 last_item_index = header->count - 1;
 
-	if (index < last_item_index) {
+	// NOTE (Abdelrahman): Extract into a variable to get rid of MSVC Spectre mitigation warnings
+	b8 is_last_item = index == last_item_index;
+	if (!is_last_item) {
 		void *cur_item  = arrayGetItemWithOffset(array, header->item_size * index);
 		void *last_item = arrayGetItemWithOffset(array, header->item_size * last_item_index);
 

src/base/hash/hasher/hasher.h

@@ -5,6 +5,7 @@
 
 #include "../../stream/stream.h"
 #include "../../../common/aliases/aliases.h"
+#include "../../../common/misc/misc_utils.h"
 
 #ifdef WP_PLATFORM_CPP
 BEGIN_C_LINKAGE
@@ -30,6 +31,7 @@ typedef struct WpSiphashCtx {
 
 typedef struct WpHasherCtx {
 	WpHasherCtxType type;
+	u8 padding[4];
 	union {
 		WpSiphashCtx siphash;
 		void        *user;

src/base/hash/hasher/murmur3.c

@@ -29,7 +29,7 @@ WpHasher wpX64Mur3HasherWithSeed(u32 seed) {
 WpU128 wpX64Mur3GetHash128(WpU8Stream *bytes, WpHasherCtx ctx) {
 	validateMur3HasherCtx(&ctx);
 
-	const i32 nblocks = (bytes->count * bytes->item_size) / 16;
+	const i32 nblocks = (const i32)((bytes->count * bytes->item_size) / 16);
 
 	u64 h1 = ctx.murmur3;
 	u64 h2 = ctx.murmur3;

src/base/hash/table/table.c

@@ -119,12 +119,20 @@ void hashTableGrow(const WpAllocator *allocator, WpHashTable *table, u64 key_siz
 	table->buckets     = buckets;
 	table->bucket_mask = mask;
 
-	for (u64 i = 0; i < wpArrayCount(old_keys); ++i) {
-		void *key           = arrayGet(old_keys, i, key_size);
-		void *value         = table->has_values ? arrayGet(old_values, i, value_size) : NULL;
+	// NOTE (Abdelrahman): Uses a while loop instead of a for loop to get rid of
+	// MSVC Spectre mitigation warnings
+	u64 count  = wpArrayCount(old_keys);
+	u64 index  = 0;
+	b8 running = true;
+	while (running) {
+		void *key           = arrayGet(old_keys, index, key_size);
+		void *value         = table->has_values ? arrayGet(old_values, index, value_size) : NULL;
 		u64 hash            = hashTableCalcHash(table, key, key_size);
 		WpHashBucketRef ref = hashTableBucketRef(table, hash);
 		hashTableInsert(table, key, value, ref, key_size, value_size);
+
+		++index;
+		running = index < count;
 	}
 }
 
@@ -132,7 +140,9 @@ WpHashLookupResult hashTableLookup(WpHashTable *table, void *key, WpHashBucketRe
 	hashTableValidate(table, key_size, 0);
 	wpDebugAssert(key != NULL, "`key` should not be NULL");
 
-	while (true) {
+	u64 initial_bucket_index = ref.bucket_index;
+	b8 running               = true;
+	while (running) {
 		WpHashBucket *bucket = &table->buckets[ref.bucket_index];
 
 		if (ref.dist_and_tag == bucket->dist_and_tag) {
@@ -152,7 +162,16 @@ WpHashLookupResult hashTableLookup(WpHashTable *table, void *key, WpHashBucketRe
 
 		ref.dist_and_tag = hashTableDistInc(ref.dist_and_tag);
 		ref.bucket_index = hashTableNextBucket(table, ref.bucket_index);
+
+		// Break if we loop back to the start bucket index
+		running = ref.bucket_index != initial_bucket_index;
 	}
+
+	return (WpHashLookupResult){
+		.ref.dist_and_tag = ref.dist_and_tag,
+		.ref.bucket_index = ref.bucket_index,
+		.found            = false,
+	};
 }
 
 void hashTableUpdate(WpHashTable *table, void *value, WpHashBucketRef ref, u64 value_size) {
@@ -172,7 +191,10 @@ void hashTableInsert(WpHashTable *table, void *key, void *value, WpHashBucketRef
 	wpDebugAssert(key != NULL, "`key` should not be NULL");
 
 	u64 index = wpArrayCount(table->keys);
-	while (true) {
+
+	// NOTE (Abdelrahman): Extract into a variable to satisfy MSVC
+	b8 running = true;
+	while (running) {
 		WpHashBucket *bucket = &table->buckets[ref.bucket_index];
 
 		if (bucket->dist_and_tag == 0) {
@@ -202,7 +224,9 @@ void hashTableRemove(WpHashTable *table, WpHashBucketRef ref, u64 key_size, u64
 
 	u64 last_item_index = wpArrayCount(table->keys) - 1;
 
-	if (bucket->item_index < last_item_index) {
+	// NOTE (Abdelrahman): Extract into a variable to get rid of MSVC Spectre mitigation warnings
+	b8 is_last_item = bucket->item_index == last_item_index;
+	if (!is_last_item) {
 		// Update the bucket for the last item before swapping
 		u64 hash = hashTableCalcHash(table, arrayGet(table->keys, last_item_index, key_size), key_size);
 

src/base/hash/table/table.h

@@ -25,6 +25,7 @@
 #include "../../stream/stream.h"
 #include "../../../common/aliases/aliases.h"
 #include "../../../common/platform/platform.h"
+#include "../../../common/misc/misc_utils.h"
 
 #ifdef WP_PLATFORM_CPP
 BEGIN_C_LINKAGE
@@ -56,7 +57,7 @@ typedef struct WpHashTable {
 	u64               magic;
 	u64               bucket_mask;
 	f32               load_factor;
-	b8                has_values;
+	b32               has_values;
 } WpHashTable;
 
 typedef struct WpHashBucketRef {
@@ -66,7 +67,9 @@ typedef struct WpHashBucketRef {
 
 typedef struct WpHashLookupResult {
 	WpHashBucketRef ref;
-	b8              found;
+	b32             found;
+
+	wpMiscUtilsReservePadding(sizeof(WpHashBucketRef) + sizeof(b32));
 } WpHashLookupResult;
 
 void               hashTableAlloc(const WpAllocator *allocator, WpHashTable *table,

src/base/mem/allocator/mem_allocator.c

@@ -94,6 +94,7 @@ b8 wpMemAllocatorOpSupported(const WpAllocator *allocator, WpMemOp op) {
 			return allocator->temp_begin != NULL;
 		case WP_MEM_OP_TEMP_END:
 			return allocator->temp_end != NULL;
+		case COUNT_MEM_OPS:
 		default:
 			break;
 	}

src/log/log.c

@@ -3,6 +3,7 @@
 #include "log.h"
 #include "../base/strings/str8/str8.h"
 #include "../common/aliases/aliases.h"
+#include "../common/platform/platform.h"
 #include "../common/assert/assert.h"
 #include "../common/misc/misc_utils.h"
 #include "../os/file/file.h"
@@ -11,9 +12,9 @@
 #define MIN_LOG_MSG_LENGTH 128
 #define TIME_BUF_CAPACITY 70
 
-wp_intern WpStr8RO L_BRACKET         = wpStr8LitRo("[");
-wp_intern WpStr8RO R_BRACKET_SPACE   = wpStr8LitRo("] ");
-wp_intern WpStr8RO R_BRACKET_NEWLINE = wpStr8LitRo("]\n");
+wp_intern WpStr8RO L_BRACKET         = wpStr8LitRoInitialiserList("[");
+wp_intern WpStr8RO R_BRACKET_SPACE   = wpStr8LitRoInitialiserList("] ");
+wp_intern WpStr8RO R_BRACKET_NEWLINE = wpStr8LitRoInitialiserList("]\n");
 
 typedef struct LogConfig {
 	WpFile *outlog;
@@ -101,14 +102,20 @@ wp_intern void getCurrentTimeString(WpStr8 *dst) {
 	char buf[TIME_BUF_CAPACITY];
 	time_t now = time(NULL);
 	struct tm utc;
+
+#ifdef WP_PLATFORM_WINDOWS
+	gmtime_s(&utc, &now);
+#else
 	gmtime_r(&now, &utc);
+#endif
+
 	strftime(buf, sizeof(buf), "%FT%TZ ", &utc);
 	wpStr8CopyCstrCapped(dst, buf);
 }
 
 wp_intern void writeLogLine(WpFile *fp, const WpLogger *logger, WpStr8 msg, WpLogLevel level) {
 	WpStr8 padding     = wpStr8Buf(MIN_LOG_MSG_LENGTH);
-	u32 padding_size = msg.size < MIN_LOG_MSG_LENGTH ? MIN_LOG_MSG_LENGTH - msg.size + 1 : 0;
+	u32 padding_size = (u32)(msg.size < MIN_LOG_MSG_LENGTH ? MIN_LOG_MSG_LENGTH - msg.size + 1 : 0);
 	wpStr8Format(&padding, "%-*s", padding_size, " ");
 
 	WpStr8 time_str = wpStr8Buf(TIME_BUF_CAPACITY);
@@ -127,7 +134,14 @@ wp_intern void writeLogLine(WpFile *fp, const WpLogger *logger, WpStr8 msg, WpLo
 		&R_BRACKET_NEWLINE
 	);
 
-	for (u64 i = 0; i < wpArrayCount(strings); ++i) {
-		wpFileWriteStr8(strings[i], fp);
+	// NOTE (Abdelrahman): Uses a while loop instead of a for loop to get rid of
+	// MSVC Spectre mitigation warnings
+	u64 count  = wpArrayCount(strings);
+	u64 index  = 0;
+	b8 running = true;
+	while (running) {
+		wpFileWriteStr8(strings[index], fp);
+		++index;
+		running = index < count;
 	}
 }

src/log/log.h

@@ -23,7 +23,7 @@ typedef enum WpLogLevel {
 } WpLogLevel;
 
 typedef struct WpLogger {
-	WpStr8RO name;
+	WpStr8 name;
 } WpLogger;
 
 #ifdef WP_PLATFORM_CPP

src/prng/splitmix64/splitmix64.c

@@ -67,7 +67,7 @@ wp_intern void seedOsGenerator(u64 seed) {
 		seed = (u64)ts.tv_nsec;
 	}
 
-	srand(seed);
+	srand((u32)seed);
 }
 
 wp_intern u64 genRandomNumber(void) {

src/prng/xorshift/xorshift.c

@@ -13,7 +13,10 @@ WpXor256State wpPrngXorshiftInit(void) {
 
 WpXor256State wpPrngXorshiftInitWithSeed(u64 seed) {
 	WpSplitmix64State sm64;
-	if (seed > 0) {
+
+	// NOTE (Abdelrahman): Extract into a variable to get rid of MSVC Spectre mitigation warnings
+	b8 seed_not_zero = seed > 0;
+	if (seed_not_zero) {
 		sm64 = wpPrngSplitmix64InitWithSeed(seed);
 	} else {
 		sm64 = wpPrngSplitmix64Init();