From f61cb3cae05b9ef3984773f5127e8da33e221814 Mon Sep 17 00:00:00 2001 From: Abdelrahman Date: Sun, 17 May 2026 10:17:36 +0100 Subject: [PATCH] Minor shell commander tweaks --- src/os/shell/commander/commander.c | 2 +- src/os/shell/commander/commander.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/os/shell/commander/commander.c b/src/os/shell/commander/commander.c index 3c55a86..b48c91a 100644 --- a/src/os/shell/commander/commander.c +++ b/src/os/shell/commander/commander.c @@ -86,7 +86,7 @@ EXECUTE_COMMAND_CLOSE: wapp_intern CMDError get_command_output(FILE *fp, CMDOutHandling out_handling, Str8 *out_buf) { Str8 out = wapp_str8_buf(OUT_BUF_LEN); - out.size = fread((void *)out.buf, sizeof(u8), out.capacity, fp); + out.size = fread((void *)out.buf, sizeof(c8), out.capacity, fp); if (out_handling == SHELL_OUTPUT_CAPTURE && out_buf != NULL) { if (out.size >= out_buf->capacity) { return SHELL_ERR_OUT_BUF_FULL; diff --git a/src/os/shell/commander/commander.h b/src/os/shell/commander/commander.h index 01d0385..b4c6f6f 100644 --- a/src/os/shell/commander/commander.h +++ b/src/os/shell/commander/commander.h @@ -10,6 +10,8 @@ #include #include +// TODO (Abdelrahman): This module needs rethinking + #ifdef WAPP_PLATFORM_CPP BEGIN_C_LINKAGE #endif // !WAPP_PLATFORM_CPP